[Bug 450050] Review Request: cgilib - A C library for creating Common Gateway Interface ("CGI") programs
bugzilla at redhat.com
bugzilla at redhat.com
Fri Nov 14 17:34:44 UTC 2008
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=450050
Lucian Langa <cooly at gnome.eu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |cooly at gnome.eu.org
--- Comment #3 from Lucian Langa <cooly at gnome.eu.org> 2008-11-14 12:34:43 EDT ---
%files for the -devel package has no %defattr
cgilib.x86_64: W: file-not-utf8 /usr/share/doc/cgilib-0.6/readme
The character encoding of this file is not UTF-8. Consider converting it in
the specfile's %prep section for example using iconv(1).
please also consider preserve installed and/or modified files timestamps:
- above iconv operation
- make install target
please explain why do you need to use autotools patch.
You need to contact upstream for such modifications, anyway it should not be
handled in the spec file.
As I see it radically changes the source package.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list