[Bug 225897] Merge Review: ImageMagick

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225897





--- Comment #13 from Orcan 'oget' Ogetbil <orcanbahri at yahoo.com>  2008-11-14 13:09:35 EDT ---
Thanks for the update!

> > * Packages must NOT contain any .la libtool archives, these should be removed
> > in the spec. In my mock build the current ImageMagick rpm contains .la files in
> >    /usr/lib64/ImageMagick-6.4.0/modules-Q16/coders/
> > 
> 
> 
> The .la files are still needed, see bug 185237, also as these are not in the
> standard library path, so they can do no harm.
> 

I realized that. I have got confused because when I built and installed
ImageMagick without .la files, it worked. But I was sloppy enough to forget to
remove the old .la files from a previous installation. So keeping them is
*required*.

> > * Is there a particular reason why you don't Require:
> > libpng-devel,libtiff-devel,libwmf-devel,libxml2-devel in the -devel package?
> > 
> 
> Because non of the ImageMagick headers use headers from these packages, it
> would be nice if you would check such things yourself before making comments
> like this in a review. Usually the reviewer does this the other way around he
> checks which headers from other packages the headers need, and if they are all
> Required by the -devel package.
> 

I apologize. It was towards the end of a long review... I had to be careful and
shouldn't make assumptions.

> > * You might want to use the "--enable_static=no" flag for faster compilation.
> > This might also save some lines (from the SPEC) file dedicated to removing the
> > static libraries.
> 
> I assume you mean --disable-static, done.
> 

./configure --help doesn't tell a --disable-static flag. If it works one way or
the other, it's fine.

> > * Adding djvu and jbig supports will be nice (although not necessary).
> > 
> 
> jbig is patented and thus not included in Fedora

Ok. What about djvu? All you need to do is add a BR: djvulibre-devel . It is
enabled by the default ./configure

Two more things:
* There are two items (a directory and a file) that are in the source but do
not end up in any of the packages:

   *** The files inside www/source/ are referenced in the docs. See, for
       example:
          file:///usr/share/doc/ImageMagick-6.4.5/www/magick-wand.html
          file:///usr/share/doc/ImageMagick-6.4.5/www/magick-core.html
       But the directory www/source isn't included in the -doc subpackage. I
       think it is a flaw of the Makefile script. Could you manually 
       insert that directory into the -doc subpackage?

   *** Similarly, the file www/Magick++/COPYING doesn't end up in any 
       subpackage. I think this file should go to the %doc of 
       ImageMagick-c++ .

* rpmlint says now:
   ImageMagick.x86_64: W: shared-lib-calls-exit
/usr/lib64/libMagickWand.so.1.0.0 exit at GLIBC_2.2.5
This seems rather annoying. It is hard (or more appropriately, time-consuming)
to check the entire code to see when these calls are made. Shall we ask the
upstream if these calls would break anything or have you investigated the
situation already?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.