[Bug 470177] Review Request: perl-Module-Util - Module name tools and transformations

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=470177


Jason Tibbitts <tibbs at math.uh.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #1 from Jason Tibbitts <tibbs at math.uh.edu>  2008-11-14 14:12:17 EDT ---
I note that 1.05 came out the day after you submitted this package.  It doesn't
look like there's any significant differences between that and 1.04, so I'll go
ahead and approve this package and if you like you can update when you check
in.

* source files match upstream.  sha256sum:
   e3c556064dcf8fad412ddcf151bce5a23975f4e9ca966d02b55bd1bd1f1cbfc6  
   Module-Util-1.04.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint is silent.
* final provides and requires are sane:
   perl(Module::Util) = 1.04
   perl-Module-Util = 1.04-1.fc10
  =
   /usr/bin/perl
   perl(:MODULE_COMPAT_5.10.0)
   perl(Exporter)
   perl(ExtUtils::MakeMaker)
   perl(File::Spec::Functions)
   perl(Getopt::Long)
   perl(List::Util)
   perl(Module::Util)
   perl(Pod::Usage)
   perl(strict)
   perl(warnings)

* %check is present and all tests pass:
   Files=2, Tests=45,  0 wallclock secs ( 0.01 usr  0.01 sys +  0.05 cusr  0.01 
    csys =  0.08 CPU)
   Result: PASS

* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.