[Bug 471522] Review Request: OTL - OTL library for database connections and queries

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=471522


Peter Lemenkov <lemenkov at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #6 from Peter Lemenkov <lemenkov at gmail.com>  2008-11-15 12:02:16 EDT ---
REVIEW:

+ rpmlint is (almost) silent:

[petro at Sulaco SPECS]$ rpmlint ../RPMS/noarch/otl-devel-4.0.176-4.fc9.noarch.rpm 
otl-devel.noarch: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
[petro at Sulaco SPECS]$ rpmlint ../SRPMS/otl-devel-4.0.176-4.fc9.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[petro at Sulaco SPECS]$

+ The package is named according to the Package Naming Guidelines .
+ The spec file name matches the base package %{name}, in the format
%{name}.spec.
+ The package meets the Packaging Guidelines .
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines .
+ The License field in the package spec file matches the actual license (BSD).
+ The spec file is written in American English.
+ The spec file for the package is legible.
+ The sources used to build the package matches the upstream source, as
provided in the spec URL.

[petro at Sulaco SOURCES]$ md5sum otlv4_h.zip*
16b07c774b737bd9fa0d8e0d3a569c67  otlv4_h.zip
16b07c774b737bd9fa0d8e0d3a569c67  otlv4_h.zip.from_srpm
[petro at Sulaco SOURCES]$

+ The package successfully compiles and build into binary rpms on at least one
supported architecture (ppc).
+ No additional build dependencies
+ No need to handle locales
+ Does not contain shared library files
+ The package owns all directories that it creates.
+ The package does not contain any duplicate files in the %files listing.
+ Permissions on files are set properly.
+ The package has a %clean section, which contains rm -rf $RPM_BUILD_ROOT .
+ The package consistently uses macros, as described in the macros section of
Packaging Guidelines .
+ The package contains code, or permissable content.
+ Does not contain large documentation files
+ Does not contain %doc files
+ Header files are in a -devel package.
+ Does not contain static libraries
+ Does not contain pkgconfig(.pc) files
+ Does not contain  library files with a suffix
+ Does not contain any .la libtool archives
+ No a GUI application
+ The package does not own files or directories already owned by other
packages.
- At the beginning of %install, the package runs rm -rf  $RPM_BUILD_ROOT
+ All filenames in rpm packages are valid UTF-8.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.