[Bug 469955] Review Request: fprintd - D-Bus service for Fingerprint reader access

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469955





--- Comment #2 from Bastien Nocera <bnocera at redhat.com>  2008-11-18 14:03:33 EDT ---
(In reply to comment #1)
> Some issues I noticed at my first check:
> 
> - Why do you need a Conflict with pam_fprint, are Obsolutes/Provides not better
> fitted here?
> https://fedoraproject.org/wiki/Packaging/Conflicts

It's not stable/tested enough to replace pam_fprint. So I'm currently only
conflicting with it.

> - Source0 is not a URL and it is not explained how to create the source
> https://fedoraproject.org/wiki/Packaging/SourceURL

True, will fix.

> - Is it intentional that the config files in /etc are not marked as %config?

Yes and no. %{_sysconfdir}/fprintd.conf should be marked as %config, but it
doesn't actually do anything useful yet, so it's better to just have it
replaced for now. I should add a comment about it.

> Btw. the release string of the linked libfprint seems to be wrong, it should be
> 0.1.pre.fc10 instead of 1.pre.fc10

That should be fixed, I updated libfprint in F11:
http://koji.fedoraproject.org/koji/taskinfo?taskID=938201

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.