[Bug 472098] Review Request: dekiwiki - a powerful opensource wiki which runs on Mono

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=472098


David Nalley <david at gnsa.us> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at gnsa.us
               Flag|                            |needinfo?(services at mindtouc
                   |                            |h.com)




--- Comment #1 from David Nalley <david at gnsa.us>  2008-11-18 14:45:14 EDT ---
Hi Mathieu, 

I'll do a quick informal review as I can't sponsor you, but hopefully it will
get you in better shape for reviews down the road. 

Using rpmlint:

./dekiwiki.spec:11: W: hardcoded-packager-tag services at mindtouch.com

Fedora packages don't specify the packager for a number of different reasons -
so a quick removal of that line will take care of at least one error. 

./dekiwiki.spec:13: W: unversioned-explicit-provides mono(mindtouch.dream)

There is no version number with mindtouch.dream and there should be so that
version changes become more obvious. 

./dekiwiki.spec:50: W: setup-not-quiet

No one wants to see all of the output of installation when using an rpm. 

./dekiwiki.spec: E: no-cleaning-of-buildroot %install

It actually looks like you are cleaning the buildroot. It may be looking for
the line without the brackets. 

./dekiwiki.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line
155)

Obvious 


In addition I noticed in the installation instructions that you had: 

yum install wv links pdftohtml tidy

You probably want to add those as requires in your spec file. 

Obviously princexml can't be included, but perhaps dompdf or a similar html2pdf
app that's licensed as open source as be used.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.