[Bug 472149] Review Request: refmac-dictionary - chemical ligand dictionaries

bugzilla at redhat.com bugzilla at redhat.com
Wed Nov 19 09:47:01 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=472149


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |panemade at gmail.com




--- Comment #1 from Parag AN(पराग) <panemade at gmail.com>  2008-11-19 04:47:00 EDT ---
suggestions
1) rpmlint is NOT silent for SRPM and for RPM.
refmac-dictionary.noarch: W: no-version-in-last-changelog
refmac-dictionary.src: W: no-version-in-last-changelog
==> missing version from changelog. Follow guidelines 
http://fedoraproject.org/wiki/PackagingGuidelines#Changelogs

2) Don't mix macros follow
http://fedoraproject.org/wiki/PackagingGuidelines#Macros
either use %{buildroot}  OR $RPM_BUILD_ROOT

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list