[Bug 466737] Review Request: matio - Library for reading/writing Matlab MAT files

bugzilla at redhat.com bugzilla at redhat.com
Wed Nov 19 20:59:37 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=466737





--- Comment #15 from Chitlesh GOORAH <cgoorah at yahoo.com.au>  2008-11-19 15:59:35 EDT ---
Can you update the spec please with respect to the above comments ?

I support Jason Tibbitts's comments. Please do comment your spec properly and
removed useless commented lines that confuse the reviewer.

Also, in the description, change "libmatio" to "matio" (first word)

For:
>> # According to the README - zlib 1.2.2 is possible but require a patch
>> BuildRequires:  zlib-devel >= 1.2.3
Even F-7 has zlib-devel 1.2.3. Drop the version and the comment

Is it useful to add doxygen commands in the spec file ? I understand the
BuildRequires: doxygen. It is needed for the compilation, however extra doxygen
commands in the spec file ?


remove this %define _default_patch_fuzz 2, the package builds fine without it
on F-8. Remember early next year, the F-8 will not be supported.

Did you mock matio?
sh: latex: command not found
Problems running latex. Check your installation or look for typos in
_formulas.tex and check _formulas.log!
sh: dvips: command not found
Problems running dvips. Check your installation!
cd latex;.././format_api.sh;.././textopdf.sh
.././textopdf.sh: line 3: pdflatex: command not found
.././textopdf.sh: line 4: makeindex: command not found
.././textopdf.sh: line 5: pdflatex: command not found

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list