[Bug 472337] Review Request: fabric - A simple pythonic remote deployment tool

bugzilla at redhat.com bugzilla at redhat.com
Thu Nov 20 13:43:31 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=472337


Fabian Affolter <fabian at bernewireless.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fabian at bernewireless.net




--- Comment #1 from Fabian Affolter <fabian at bernewireless.net>  2008-11-20 08:43:30 EDT ---
Just some quick comments on your spec file (without any deep investigation ;-)
):

- 'License: GPLv2' The license should be GPLv2+. Take a look at the headers of
the source: "or (at your option) any later version"

- Replace 'BuildRequires: python-devel' with 'BuildRequires: python'
  https://fedoraproject.org/wiki/Packaging/Python#BuildRequires

- Do you really need 'Requires: python-setuptools' ?

- add TODO to %doc

- 'Requires: python-paramiko < 2' is from my point of view not necessary
because the current version of paramiko is 1.7.4

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list