[Bug 463767] Review Request: cloog - The Chunky Loop Generator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463767





--- Comment #9 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2008-11-20 13:32:03 EDT ---
For -0.2

! First of all, you can try to check your package by rpmlint
  (in rpmlint package). rpmlint detects some general packaging
  issues.

Then:
* Requires
-----------------------------------------------------------
Requires: ppl-devel >= 0.10, gmp-devel >= 4.1.3
-----------------------------------------------------------
  - This should be for cloog-devel package, not for cloog package

* Group
  - Group for -devel subpackage should be "Development/Libraries",
    not "Development/Library"

* %_infodir/dir
  - This file must not be installed. Overwriting this file
    by this rpm breaks system "info" information.

    * Please remove this file at %install (not %clean)
      and remove this file from %files
    * And restore the previous %clean

* Shipping static archives
  - What I meant is that unless some specific reason static
    archive libfoo.a must be removed (as well as libtool .la
    file)

* calling ldconfig on scriptlet
  - When using "%post -p /sbin/ldconfig" (i.e. using /sbin/ldconfig
    directly instead of calling bash and executing ldconfig in the
    shell script), no other additional scriptlets are allowed.

    i.e. if there is some other scriptlets than /sbin/ldconfig,
    you have to write like:
----------------------------------------------------------
%post
/sbin/ldconfig
/sbin/install-info %{_infodir}/%{name}.info %{_infodir}/dir || :
----------------------------------------------------------

* %changelog
  - git revision differs between %release and %change.log

? Some header files design flaw
  - Well, for example the head of %_includedir/cloog/cloog.h
    says:
----------------------------------------------------------
    40  #ifndef CLOOG_H
    41  #define CLOOG_H
    42  
    43  #ifdef CLOOG_PPL_BACKEND
    44  # define GNUMP
    45  # include<cloog/ppl_backend.h>
    46  #else
    47  # include <polylib/missing.h>
    48  # include<cloog/polylib_backend.h>
    49  #endif
----------------------------------------------------------
    However, where can we tell if CLOOG_PPL_BACKEND is defined
    or not (when this package was built) (i.e whether this header
    file includes ppl_backend.h or polylib_backend.h)?
    build.log shows that when rebuilding this package -DCLOOG_PPL_BACKEND
    is used, however installed header files does not save such
    information....

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.