[Bug 471915] Review Request: jbossweb2 - JBoss Web Server based on Apache Tomcat

Fri Nov 21 19:06:12 UTC 2008

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=471915

--- Comment #12 from Permaine Cheung <pcheung at redhat.com>  2008-11-21 14:06:11 EDT ---
Naming - OK
Legal - OK 
Licensing - OK  - LGPLv3
No inclusion of pre-built binaries or libraries - OK, removed in %prep
verify any sources and patches :
* Should the TOMCAT_CFG file be set to /etc/jbossweb/jbossweb2.conf instead of
/etc/jbossweb/jbossweb.conf in jbossweb2-2.1-tool-wrapper.script?
verify that the license stated in the spec file matches the actual license of
the software - OK
skim the summary and description for typos and oddities - OK
make sure that the correct build root is used - OK
ensure that macro usage is consistent - OK
* rpmlint output:

[pcheung at tonka result]$ rpmlint jbossweb2-2.1.1-4.2.fc10.src.rpm
jbossweb2.src:86: E: hardcoded-library-path in /lib/lsb/init-functions
jbossweb2.src:87: E: hardcoded-library-path in /lib/lsb/init-functions
jbossweb2.src:145: W: unversioned-explicit-provides jsp21
jbossweb2.src:173: W: unversioned-explicit-provides servlet6
jbossweb2.src:174: W: unversioned-explicit-provides servlet25
jbossweb2.src: W: non-standard-group Networking/Daemons

[pcheung at tonka result]$ rpmlint jbossweb2-2.1.1-4.2.fc10.noarch.rpm
jbossweb2.noarch: E: non-standard-gid /var/cache/jbossweb2/temp jbossweb
jbossweb2.noarch: E: non-standard-dir-perm /var/cache/jbossweb2/temp 0775
jbossweb2.noarch: E: non-standard-gid /var/lib/jbossweb2/webapps jbossweb
jbossweb2.noarch: E: non-standard-dir-perm /var/lib/jbossweb2/webapps 0775
jbossweb2.noarch: W: symlink-should-be-relative /usr/share/jbossweb2/webapps
/var/lib/jbossweb2/webapps
jbossweb2.noarch: W: symlink-should-be-relative /usr/share/jbossweb2/conf
/etc/jbossweb2
jbossweb2.noarch: W: dangling-symlink /usr/share/jbossweb2/lib
/usr/share/java/jbossweb2
jbossweb2.noarch: W: symlink-should-be-relative /usr/share/jbossweb2/lib
/usr/share/java/jbossweb2
jbossweb2.noarch: E: non-standard-gid /var/cache/jbossweb2/work jbossweb
jbossweb2.noarch: E: non-standard-dir-perm /var/cache/jbossweb2/work 0775
jbossweb2.noarch: W: symlink-should-be-relative /usr/share/jbossweb2/work
/var/cache/jbossweb2/work
jbossweb2.noarch: E: non-standard-gid /etc/jbossweb2/tomcat-users.xml jbossweb
jbossweb2.noarch: E: non-readable /etc/jbossweb2/tomcat-users.xml 0660
jbossweb2.noarch: E: non-standard-gid /var/log/jbossweb2 jbossweb
jbossweb2.noarch: E: non-standard-dir-perm /var/log/jbossweb2 0775
jbossweb2.noarch: W: symlink-should-be-relative /usr/share/jbossweb2/temp
/var/cache/jbossweb2/temp
jbossweb2.noarch: W: symlink-should-be-relative /usr/share/jbossweb2/logs
/var/log/jbossweb2
jbossweb2.noarch: E: non-standard-gid /etc/jbossweb2/Catalina/localhost
jbossweb
jbossweb2.noarch: E: non-standard-dir-perm /etc/jbossweb2/Catalina/localhost
0775
jbossweb2.noarch: W: non-standard-group Networking/Daemons
jbossweb2.noarch: W: dangerous-command-in-%preun rm
jbossweb2.noarch: W: incoherent-subsys /etc/init.d/jbossweb2 ${NAME}
jbossweb2.noarch: W: incoherent-subsys /etc/init.d/jbossweb2 ${NAME}
jbossweb2.noarch: W: incoherent-subsys /etc/init.d/jbossweb2 ${NAME}
jbossweb2.noarch: W: incoherent-subsys /etc/init.d/jbossweb2 ${NAME}

[pcheung at tonka result]$ rpmlint
jbossweb2-admin-webapps-2.1.1-4.2.fc10.noarch.rpm
jbossweb2-admin-webapps.noarch: W: no-documentation
jbossweb2-admin-webapps.noarch: W: non-standard-group System
Environment/Applications

[pcheung at tonka result]$ rpmlint jbossweb2-docs-webapp-2.1.1-4.2.fc10.noarch.rpm
jbossweb2-docs-webapp.noarch: W: no-documentation
jbossweb2-docs-webapp.noarch: W: non-standard-group System
Environment/Applications

[pcheung at tonka result]$ rpmlint jbossweb2-javadoc-2.1.1-4.2.fc10.noarch.rpm

[pcheung at tonka result]$ rpmlint jbossweb2-jsp-2.1-api-2.1.1-4.2.fc10.noarch.rpm
jbossweb2-jsp-2.1-api.noarch: W: no-documentation
jbossweb2-jsp-2.1-api.noarch: W: non-standard-group Internet/WWW/Dynamic
Content

[pcheung at tonka result]$ rpmlint jbossweb2-lib-2.1.1-4.2.fc10.noarch.rpm 
jbossweb2-lib.noarch: W: no-documentation
jbossweb2-lib.noarch: W: dangling-relative-symlink
/usr/share/java/jbossweb2/jbossweb2-servlet-2.5-api-2.1.1.jar
../jbossweb2-servlet-2.5-api-2.1.1.jar
jbossweb2-lib.noarch: W: dangling-relative-symlink
/usr/share/java/jbossweb2/jbossweb2-jsp-2.1-api-2.1.1.jar
../jbossweb2-jsp-2.1-api-2.1.1.jar
jbossweb2-lib.noarch: W: non-standard-group Development/Compilers
jbossweb2-lib.noarch: W: dangerous-command-in-%preun rm

[pcheung at tonka result]$ rpmlint
jbossweb2-servlet-2.5-api-2.1.1-4.2.fc10.noarch.rpm
jbossweb2-servlet-2.5-api.noarch: W: no-documentation
jbossweb2-servlet-2.5-api.noarch: W: non-standard-group Internet/WWW/Dynamic
Content

[pcheung at tonka result]$ rpmlint jbossweb2-webapps-2.1.1-4.2.fc10.noarch.rpm
jbossweb2-webapps.noarch: W: no-documentation
jbossweb2-webapps.noarch: W: non-standard-group System Environment/Applications

Changelog - OK
Tags - OK
Requires - OK
BuildRequires - OK
Summary & description - OK
Encoding - OK
Documentation - OK
Initscripts
* Following https://fedoraproject.org/wiki/Packaging/SysVInitScript, this needs
the following :
# This is for /sbin/service
Requires(preun): initscripts

and also a # description line following right after chkconfig: line

Why does the init script use the lsb/init-functions instead of the regular one?

File and Directory ownership - OK
Users and Groups:
* Should the shell for jbossweb /sbin/nologin?
Web Applications - OK
* Should the default TOMCAT_USER be jbossweb2(instead of tomcat) in
/etc/jbossweb/jbossweb2.2.1.init?

No Files or Directories under /srv - OK

All patches should have an upstream bug link or comment:
* Please add comments for the patches

The BuildRequires and Requires section in the Java packaging guidelines have
the following:
At a minimum, Java packages MUST:

BuildRequires: java-devel [>= specific_version] 
BuildRequires:  jpackage-utils

Requires:  java >= specific_version
Requires:  jpackage-utils

For historical reasons, when specifying versions 1.6.0 or greater, an epoch of
1 must be included. Example:

Requires: java >= 1:1.6.0

Please update the BR and R to the above format.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.