[Bug 455226] Review Request: php-pecl-runkit - PHP Opcode Analyser

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=455226





--- Comment #5 from Pavel Alexeev <pahan at hubbitus.spb.su>  2008-11-23 05:50:28 EDT ---
Firstly - thank you for comment.

(In reply to comment #3)
> Small question :
> 
> Do you think it is a good idea to import a very old package which doesn't seem
> maintained upstream for quite a long time (june 2006).
This is work now and have not major bugs which must be fixed by upstream.
Furthermore, I do not known any alternatives by functionality yet. So, answer
is yes, I think is it is a very good idea to import this package.


> Small notes :
> 
> Version 0.9 is available, so you cannot use a pre-release version number
> (0.9-0.xxx) but a post release (Official 0.9 will have a 0.9-1 number schema)
Hm. It is build from CVS. How I should number its versions - 0.9-1.CVS20080512,
0.9-2.CVS20080512, 0.9-3.CVS20080512? Or 0.9-1.1.CVS20080512,
0.9-1-2.CVS20080512, 0.9-1-3.CVS20080512?

> Please add in comment the "cvs export" command with the revision or date
> retrieved.
Excuse me, I do not understand. Date of CVS retrieving present in version and
in defined macros
%define CVS 20080512
in spec file. For what and where more I should comment it?

> Also indicate where the patch come from.
This is my patches. And it is reflected in spec changelog.

> If they are needed to build against
> latest php version, you should file a bug upstream with your patch attached
> (but I see in CSV php 5.3.0 compatibility have been fixed for a few months).
Patch not for PHP, patch for this extension to make it compatible with new PHP
ABI.
So, if we speak about file bug to upstream of this pecl extension - this have
not sense, because you said before what it is old and unmaintained.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.