[Bug 472170] Review Request: perl-Check-ISA - DWIM, correct checking of an object's class

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=472170


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade at gmail.com
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
               Flag|                            |fedora-review+




--- Comment #3 from Parag AN(पराग) <panemade at gmail.com>  2008-11-24 00:16:16 EDT ---

Review:
+ package builds in mock (rawhide i386).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=947323
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
7d118aadd4069b4287f309482776a2bd  Check-ISA-0.04.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=3, Tests=83,  0 wallclock secs ( 0.02 usr  0.01 sys +  0.31 cusr  0.02
csys =  0.36 CPU)

+ Package perl-Check-ISA-0.04-1.fc11 =>
  Provides: perl(Check::ISA) = 0.04
  Requires: perl(Scalar::Util) perl(Sub::Exporter) perl(constant) perl(strict)
perl(warnings) perl(warnings::register)

APRPOVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.