[Bug 471754] Review Request: virtaal - Localization and translation editor

Mon Nov 24 11:56:11 UTC 2008

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=471754

Fabian Affolter <fabian at bernewireless.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fabian at bernewireless.net

--- Comment #3 from Fabian Affolter <fabian at bernewireless.net>  2008-11-24 06:56:10 EDT ---
Just some quick comments on your spec file.

- 'BuildRequires: python-devel' should be 'BuildRequires: python'
  https://fedoraproject.org/wiki/Packaging/Python#BuildRequires

- %{buildroot} and $RPM_BUILD_ROOT should not be mixed.

https://fedoraproject.org/wiki/Packaging/Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS

- '--vendor="fedora" \' is obsolete for new packages.
  see https://fedoraproject.org/wiki/TomCallaway/DesktopFileVendor

- remove '.fc9' in your %changelog section
  https://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.