[Bug 471829] Review Request: log4cxx - Log4cxx - a port to C++ of the Log4j project

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=471829





--- Comment #5 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2008-11-27 12:06:30 EDT ---
Well,

* Summary
  - Usually on Summary beginning with the package name 
   (Log4cxx -) is redundant

* Group
  - Usually this type of package has "System Environment/Libraries"
    Group for main package.

* SourceURL
  - For SourceURL, using %name, %version (especially %version) is
    recommended:
    https://fedoraproject.org/wiki/Packaging/SourceURL#Using_.25.7Bversion.7D

* rpath
  - Using chrpath to remove rpath should be considered as the
    last resort:
    https://fedoraproject.org/wiki/Packaging/Guidelines#Removing_Rpath
    Please don't use chrpath unless avoidable (and usually it
    is avoidable).
    * I usually use
--------------------------------------------------------------
sed -i.libdir_syssearch -e \
 '/sys_lib_dlsearch_path_spec/s|/usr/lib |/usr/lib /usr/lib64 /lib /lib64 |' \
 configure
--------------------------------------------------------------
      and this works for this package

* Timestamp
  - Please consider to use
--------------------------------------------------------------
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"
--------------------------------------------------------------
    to keep timestamps on installed files. This method usually works
    for Makefiles generated by recent autotools.

* Installed doxygen html files
  - All these files should be marked as %doc. Moreover, I suggest
    that these html files must be moved under %_datadir/doc/

* Macros
  - Requires: log4cxx = %{version}-%{release},pkgconfig
    I suggest to use %name for consistency

* Requires for -devel subpackage
  - For example %_includedir/%name/helpers/aprinitializer.h contains:
--------------------------------------------------------------
    25  #include <log4cxx/helpers/pool.h>
    26  #include <apr_pools.h>
    27  #include <apr_thread_proc.h>
--------------------------------------------------------------
    This file requires apr-devel.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.