[Bug 463217] Review Request: gnuplot-py - Python interface to Gnuplot

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463217





--- Comment #11 from Orcan 'oget' Ogetbil <orcanbahri at yahoo.com>  2008-11-28 17:57:47 EDT ---
Sorry, I was never notified that you updated the package. Anyways, I found a
few issues:

* There are broken links in the %doc html files. For example, in your browser,
go to /usr/share/doc/gnuplot-py-1.8/gp_unix.html . The Gnuplot link on the top
left is broken, which is the case for pretty much all other %doc files. Can you
fix those?

* I also ask you the include the other relevant doc files (*.txt) in the %doc .
These .txt files are referred to within the .html files (see Gnuplot.html) and
therefore we need to keep them.

You can put those happydoc generated .html files in a subdirectory inside
/usr/share/doc/gnuplot-py-1.8/ if you think that having everything in the main
%doc directory makes things confusing.

* This python package does not use setuptools. Therefore in order to create the
proper python egg, you need to follow the guideline at:
http://fedoraproject.org/wiki/Packaging/Python/Eggs#Providing_Eggs_for_non-setuptools_packages

* You don't need to package:
   /usr/lib/python2.5/site-packages/Gnuplot/setup.py*
   /usr/share/doc/gnuplot-py-1.8/setup.html
files. There are also mac, win32 etc related .py and .html files. Those aren't
very necessary either. I leave these up to you.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.