[Bug 473412] Review Request: kopete-cryptography - Encrypts and signs messages in Kopete using the OpenPGP

Fri Nov 28 23:23:51 UTC 2008

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=473412

--- Comment #2 from Till Maas <opensource at till.name>  2008-11-28 18:23:50 EDT ---
[NEEDSWORK] rpmlint output:
kopete-cryptography.i386: W: dangling-symlink
/usr/share/doc/HTML/uk/kopete-cryptography/common
/usr/share/doc/HTML/uk//common
kopete-cryptography.i386: W: symlink-should-be-relative
/usr/share/doc/HTML/uk/kopete-cryptography/common
/usr/share/doc/HTML/uk//common
kopete-cryptography.i386: W: dangling-symlink
/usr/share/doc/HTML/it/kopete-cryptography/common
/usr/share/doc/HTML/it//common
kopete-cryptography.i386: W: symlink-should-be-relative
/usr/share/doc/HTML/it/kopete-cryptography/common
/usr/share/doc/HTML/it//common
kopete-cryptography.i386: W: dangling-symlink
/usr/share/doc/HTML/fr/kopete-cryptography/common
/usr/share/doc/HTML/fr//common
kopete-cryptography.i386: W: symlink-should-be-relative
/usr/share/doc/HTML/fr/kopete-cryptography/common
/usr/share/doc/HTML/fr//common
kopete-cryptography.i386: W: dangling-symlink
/usr/share/doc/HTML/en/kopete/plugins/cryptography/common
/usr/share/doc/HTML/en/common
kopete-cryptography.i386: W: symlink-should-be-relative
/usr/share/doc/HTML/en/kopete/plugins/cryptography/common
/usr/share/doc/HTML/en/common
kopete-cryptography.i386: W: dangling-symlink
/usr/share/doc/HTML/pt/kopete-cryptography/common
/usr/share/doc/HTML/pt//common
kopete-cryptography.i386: W: symlink-should-be-relative
/usr/share/doc/HTML/pt/kopete-cryptography/common
/usr/share/doc/HTML/pt//common
kopete-cryptography.i386: W: dangling-symlink
/usr/share/doc/HTML/sv/kopete-cryptography/common
/usr/share/doc/HTML/sv//common
kopete-cryptography.i386: W: symlink-should-be-relative
/usr/share/doc/HTML/sv/kopete-cryptography/common
/usr/share/doc/HTML/sv//common

I believe that adding somethin like this to the HTML doc loop in %install
should fix this, but the second line breaks the build currently and I am too
tired to see why. :-/

test -L $lang_dir/kopete-cryptography/common && ln -sf ../common
$lang_dir/kopete-cryptography/common
test -L $lang_dir/kopete/plugins/cryptography/common && ln -sf ../../../common
$lang_dir/kopete/plugins/cryptography/common

[OK] Spec in %{name}.spec format

[OK] license allowed: GPLv2+
[OK] license matches shortname in License: tag
[OK] license in tarball and included in %doc:

[OK] package is code or permissive content:
{N/A} patches sent to upstream and commented
[OK] Source0 is a working URL
{N/A} Sourceforge URL is Source0:
http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz
<N/A> SourceX / PatchY prefixed with %{name}
[OK] Source0 matches Upstream:
25697c1b7f85c660f4cfc73b27c2e4c8  kopete-cryptography-1.3.0-kde4.1.3.tar.bz2

[OK] Package builds on all platforms:
http://koji.fedoraproject.org/koji/taskinfo?taskID=956882
[N/A] ExcludeArch bugs are filed and commented:
[OK] BuildRequires are complete (mock builds)
(OK) No file dependencies outside of /etc /bin /sbin /usr/bin /usr/sbin 
https://fedoraproject.org/wiki/Packaging/Guidelines#FileDeps

[OK] %find_lang used for locales

[N/A] Every (sub)package containing libraries runs ldconfig
%post -p /sbin/ldconfig
%postun -p /sbin/ldconfig
[N/A] .h (header) files are in -devel subpackage
[N/A] .a (static libraries) are in -static subpackage
[N/A] contains .pc (pkgconfig) files and has Requires: pkgconfig
(N/A) .pc files are in -devel subpackage
[N/A] contains .so.X(.Y) files and .so is in -devel
[N/A] -devel subpackage has Requires: %{name} = %{version}-%{release}
[N/A] .la files (libtool) are not included

[N/A] Has GUI and includes %{name}.desktop
[N/A] Follows desktop entry spec
[N/A] Valid .desktop Name
[N/A] Valid .desktop GenericName
[N/A] Valid .desktop Categories
[N/A] Valid .desktop StartupNotify
[N/A] .desktop file installed with desktop-file-install in %install

[OK] Prefix: /usr not used (not relocatable)

[NEEDSWORK] Owns all created directories:
/usr/share/kde4/apps/kopete_cryptography/ should probably be owned

[OK] no duplicates in %files
[OK] %defattr(-,root,root,-) is in every %files section
[OK] Does not own files or dirs from other packages
[OK] included filenames are in UTF-8
[OK] %clean is rm -rf %{buildroot} or $RPM_BUILD_ROOT 
[OK] %install starts with rm -rf %{buildroot} or $RPM_BUILD_ROOT 

[NEEDSWORK] Consistent macro usage
https://fedoraproject.org/wiki/Packaging/Guidelines#macros

$RPM_BUILD_ROOT and %{buildroot} are used

[OK] large documentation is -doc subpackage
[TODO] %doc does not affect runtime

{OK} no pre-built binaries (.a, .so*, executable)
{OK} well known BuildRoot
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
{OK} PreReq not used

{OK} RPM_OPT_FLAGS honoured
Only visibile when VERBOSE=1 is used.

{OK} Useful debuginfo generated
{OK} no duplication of system libraries
{OK} no rpath

{TODO} Timestamps preserved with cp and install
https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps

{OK} Uses parallel make (%{?_smp_mflags})
{OK} Requires(pre,post) style notation not used
{OK} only writes to tmp /var/tmp $TMPDIR %{_tmppath} %{_builddir} (and
%{buildroot} on %install and %clean)
{OK} no Conflicts
{OK} nothing installed in /srv
{OK} Changelog in allowed format
{OK} does not use Scriptlets

<N/A> Architecture independent packages have: BuildArch: noarch
<OK> Sane Provides: and Requires:
{OK} Follows Naming Guidelines

{NEEDSWORK} follows special guidelines
Cmake
https://fedoraproject.org/wiki/Packaging/cmake
VERBOSE=1 is missing at the make commandline in %build

Btw. are there any KDE specific guidelines available? At the KDE SIG page there
is a "best practices" headline, but there is no content available:
https://fedoraproject.org/wiki/SIGs/KDE#Best_Practices

I will check the two missing items tomorrow, but I am too tired now. Please fix
or comment the items marked with NEEDSWORK.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.