[Bug 472724] Review Request: xjparse - wrapper for the Xerces XML Schema validator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=472724


Dominik 'Rathann' Mierzejewski <rpm at greysector.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |rpm at greysector.net
               Flag|                            |fedora-review?




--- Comment #4 from Dominik 'Rathann' Mierzejewski <rpm at greysector.net>  2008-11-30 11:11:36 EDT ---
MD5 sum matches upstream.

$ md5sum xjparse-src-1.0.zip
8722e59eb5b7b1d1adebd8f39b8f93db  xjparse-src-1.0.zip


Some comments:

Group:          Applications/Text       
License:        ASL 2.0 

These two lines have trailing whitespace.


%description
The xjparse tool is a simple command-line wrapper for the Xerces XML Schema
validator. It accepts several options, notably one which specifies the set of
 schemas to be used during validation.

Nitpick: move "of" to the beginning of the following line.


cp -p build/xjparse.jar \ 
$RPM_BUILD_ROOT%{_javadir}/%{name}-%{version}.jar

You might also need this:
ln -s %{name}-%{version}.jar $RPM_BUILD_ROOT%{_javadir}/%{name}.jar
Otherwise you need to specify xjparse-1.0 instead of just xjparse in
build-classpath call to run it:
java -cp `build-classpath xjparse-1.0 xml-commons-resolver`
com.nwalsh.parsers.xjparse
But if that's intentional then I have no objection. Most .jars installed in
%{_javadir} do have such symlinks though.


%files
%defattr(-,root,root,-)
%{_javadir}/*

I know the template has this, but I'd rather you put the full path of the files
that get installed here, i.e.
%{_javadir}/%{name}-%{version}.jar
%{_javadir}/%{name}.jar


* Tue Nov 25 2008 Brennan Ashton <bashton at, brennanashton.com> 1.0-2
- Now noarch
- Fixed discription line length
* Sun Nov 23 2008 Brennan Ashton <bashton at, brennanashton.com> 1.0-1
- Created spec file

Put an empty line between changelog entries.

You were asking what to do if there's no licence text included in the source
archive:
- SHOULD: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.

Please do this then.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.