[Bug 453412] Review Request: gtk-aurora-engine - Aurora theme engine for gtk2

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=453412


John Anderson <john.e.anderson at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |john.e.anderson at gmail.com




--- Comment #1 from John Anderson <john.e.anderson at gmail.com>  2008-09-30 21:34:40 EDT ---
I'm looking for sponsorship as well, so I can't do a full review, but I'd like
to point out a few things.

1) It would be nice if you could link directly to the source. I notice 
http://www.gnome-look.org/CONTENT/content-files/56438-Aurora-1.4.tar.bz2
seems to work for the main source file.

2) Add a -q to your %setup

3) The permissions in source1 are kind of screwy. You can fix them in the files
section with something like this:

%attr(755, -, root) %{_datadir}/themes/*
%attr(644, -, root) /usr/share/themes/Aurora-Midnight/gtk-2.0/gtkrc
%attr(644, -, root) /usr/share/themes/Aurora/gtk-2.0/gtkrc
%attr(644, -, root) /usr/share/themes/Aurora-looks/gtk-2.0/gtkrc

Otherwise, it looks good to me. It builds and installs fine against rawhide.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.