[Bug 463996] Review Request: tuxguitar - A multitrack tablature editor and player written in Java-SWT

Wed Oct 1 20:39:52 UTC 2008

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=463996

--- Comment #20 from Orcan Ogetbil <orcanbahri at yahoo.com>  2008-10-01 16:39:51 EDT ---
(In reply to comment #19)
> Created an attachment (id=319139)
 --> (https://bugzilla.redhat.com/attachment.cgi?id=319139) [details]
> crash log when tuxguitar exits
> 
> For 1.0-5:
> 
> * Requires
>   - I guess at least "Requires: libswt3-gtk2" is missing.
> 

Yes, in update 1.0-2 I had removed that Requirement because rpmlint complained
about explicit library dependency. But as it seems rpmbuild does not pick up
this dependency automatically. Hence I re-included it.
FIXED

> * Using build-classpath
>   - For example
> --------------------------------------------------------
> make SWT_JAR=%{_libdir}/java/swt.jar CFLAGS="${RPM_OPT_FLAGS}
> -I%{openjdkdir}/include -I%{openjdkdir}/include/linux -fPIC"
> --------------------------------------------------------
>     I guess using
> --------------------------------------------------------
> make SWT_JAR=$(build-classpath swt) CFLAGS=.....
> --------------------------------------------------------
>     is more portable on Fedora (see:
>     https://fedoraproject.org/wiki/Packaging/Java#build-classpath )
> 

I had tried that. It does not work. Maybe because %{_libdir}/java/swt.jar is a
symlink. But the actual jar file is
%{_libdir}/eclipse/plugins/org.eclipse.swt.gtk.linux.x86_64_3.3.2.v3349.jar

I don't think SWT_JAR=$(build-classpath
org.eclipse.swt.gtk.linux.x86_64_3.3.2.v3349) is a good solution.

NOT FIXED(?)

>     ! Note:
>       Usually the environment CLASSPATH is not set by default.
>       As far as I see misc/tuxguitar.sh when this script is called
>       CLASSPATH seems to be set finally like:
> --------------------------------------------------------
> :/usr/share/tuxguitar/tuxguitar.jar:/usr/lib/java/swt.jar
> --------------------------------------------------------
>       Usually any environment value with begin with colon is
>       unwilling (same for LD_LIBARARY_PATH)
> 
FIXED

> * Some script improvement
>   * desktop-file-install
> --------------------------------------------------------
> install -pm 644 %{SOURCE9} $RPM_BUILD_ROOT/%{_datadir}/applications/
> desktop-file-install --dir $RPM_BUILD_ROOT%{_datadir}/applications
> --delete-original $RPM_BUILD_ROOT%{_datadir}/applications/%{name}.desktop
> --------------------------------------------------------
>   - can be
> --------------------------------------------------------
> desktop-file-install \
>  --dir $RPM_BUILD_ROOT%{_datadir}/applications \
>  %{SOURCE9}
> --------------------------------------------------------
> 
FIXED

>   * installing hicolor icons
> --------------------------------------------------------
> for dim in 16x16 24x24 32x32 48x48 64x64 96x96; do
>  install -dm 755
> $RPM_BUILD_ROOT/%{_datadir}/icons/hicolor/$dim/apps/%{name}.png
>  install -pm 644 TuxGuitar/share/skins/Lavender/icon-$dim.png
> $RPM_BUILD_ROOT/%{_datadir}/icons/hicolor/$dim/apps/%{name}.png
> done
> --------------------------------------------------------
>     "$ rpm -ql tuxguitar" shows unwilling results. This creates
>     the directory named "%{_datadir}/icons/hicolor/$dim/apps/%{name}.png"
>     and installs icon under the directory.
> 
FIXED

>   * installing mime icons
> --------------------------------------------------------
> install -pm 644 TuxGuitar/share/skins/Lavender/icon-96x96.png
> $RPM_BUILD_ROOT/%{_datadir}/icons/hicolor/96x96/mimetypes/audio-x-tuxguitar.png
> install -pm 644 TuxGuitar/share/skins/Lavender/icon-96x96.png
> $RPM_BUILD_ROOT/%{_datadir}/icons/hicolor/96x96/mimetypes/audio-x-gtp.png
> install -pm 644 TuxGuitar/share/skins/Lavender/icon-96x96.png
> $RPM_BUILD_ROOT/%{_datadir}/icons/hicolor/96x96/mimetypes/audio-x-ptb.png
> ---------------------------------------------------------
>   - I guess
> ---------------------------------------------------------
> for type in \
>  tuxguitar gtp ptb
>  do
>  install -pm 644 TuxGuitar/share/skins/Lavender/icon-96x96.png \
>   $RPM_BUILD_ROOT/%{_datadir}/icons/hicolor/96x96/mimetypes/audio-x-${type}.png
> done
> ---------------------------------------------------------
>     is cleaner
> 
FIXED

> * jni
>   - jni files must be installed under %_libdir/%name:
>     https://fedoraproject.org/wiki/Packaging/Java#Guideline
> 
FIXED

> * desktop database update
>   - When installed desktop file contains MimeType key, desktop database
>     must be updated:
>     https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#desktop-database
> 
FIXED

> 
> ! By the way it seems I can heard no sound and when I
>   close tuxguitar:
> ---------------------------------------------------------
I usually use gervill or timidity plugins for sound output, for the latter you
have to start timidity (timidity -iA -Os & )in the background and this one has
the best sound quality. 

The fluidsynth plugin is kinda choppy when it's used directly. Tuxguitar does
not pick up correct buffer sizes etc. To use the fluidsynth I would recommend
starting a fluidsynth daemon in the background (e.g. one can use qsynth for
that purpose).

But I don't think this is a packaging issue. I provided the best I could from
the material I have. (but I will report the issue to upstream, for sure)

The updated files are:
SRPM(F-8): http://6mata.com:8014/tuxguitar/tuxguitar-1.0-6.fc8.src.rpm
SRPM(F-9): http://6mata.com:8014/tuxguitar/tuxguitar-1.0-6.fc9.src.rpm
SPEC: http://6mata.com:8014/tuxguitar/tuxguitar.spec

Thanks for the very extensive review!

%changelog
* Wed Oct 01 2008 Orcan Ogetbil <orcanbahri[AT]yahoo[DOT]com> - 1.0-6
- Required libswt3-gtk2 since rpmbuild doesn't pick it up.
- Some more cleanup in the spec file
- Fixed a typo regarding installation of icons
- Called update-desktop-database in %%post and %%postun
- jni files put in %%_libdir_/%%name.

* Mon Sep 29 2008 Orcan Ogetbil <orcanbahri[AT]yahoo[DOT]com> - 1.0-5
- Compiled the package with openjdk instead of gcj.
- ExcludeArch'ed ppc/ppc64 on F-8.
...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.