[Bug 464424] Review Request: GROMACS - a Molecular Dynamics package

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=464424





--- Comment #23 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2008-10-02 06:15:05 EDT ---
Some more notes:

* Directory ownership issue
  - Please make it sure that directories which are created when
    installing a rpm are correctly owned by the rpm (or rpms
    which the rpms depends on).

    The following may be rather difficult to find out, but for
    example:
----------------------------------------------------
# rpm -i gromacs-libs-4.0-6.rc2.fc10.i386.rpm
gromacs-devel-4.0-6.rc2.fc10.i386.rpm 
# env LANG=C rpm -qf /usr/share/gromacs/template/
gromacs-devel-4.0-6.rc2.fc10.i386
# env LANG=C rpm -qf /usr/share/gromacs/
file /usr/share/gromacs is not owned by any package
----------------------------------------------------
    Here gromacs-devel Requires gromacs-libs, however neither of
    -devel, -libs packages Requires -common.
    So the above install succeeds.

    However the directory %{_datadir}/gromacs is owned by -common
    package so with this install %{_datadir}/gromacs is not
    owned by any packages, which is not right.
    Here -devel package must require -common directly or indirectly.

    Also, please check the ownership of %{_datadir}/gromacs/template/ 
    or so.

* ldconfig
  - Why does -devel package call /sbin/ldconfig?

* Summary
----------------------------------------------------
%package devel
Summary: Header files and static libraries for GROMACS
----------------------------------------------------
   - What does "static" libraries mean here?

* Timestamps
  - When using "install" or "cp" commands add "-p" option to 
    keep timestamps on installed files.
    Also try
----------------------------------------------------
make DESTDIR=%{buildroot} INSTALL="install -p" install 
----------------------------------------------------
    This method usually works for Makefiles generated by recent
    autotools.

* Using %_builddir
-----------------------------------------------------
# Install manual
install -c -m 644 %{SOURCE1} %{_builddir}/gromacs-4.0_rc2/
-----------------------------------------------------
  - "install -cpm 0644 %{SOURCE1} ." is sufficient.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.