[Bug 462250] Review Request: Pmw - python megawidgets
bugzilla at redhat.com
bugzilla at redhat.com
Thu Oct 2 16:16:34 UTC 2008
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=462250
--- Comment #4 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2008-10-02 12:16:33 EDT ---
For 1.3.2-2:
* URL
- I think http://pmw.sourceforge.net/ is better for URL
* SourceURL
- For tarball on sourceforge.net please refer to
https://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net
* %prep
---------------------------------------------------
%setup -q -n Pmw.1.3.2/src
---------------------------------------------------
- After rebuilding the directory Pmw.1.3.2/src under %_builddir
But it leaved Pmw.1.3.2 directory undeleted, which is not
right.
%setup directory (relative to %_builddir) must not contain
any slash.
%build
%install
rm -rf
* License
--- Some files under src/Pmw/Pmw_1_3/contrib/ are under GPLv2+
--- Others are under MIT (from src/Pmw/Pmw_1_3/doc/copyright.html)
- So the license tag should be "MIT and GPLv2+".
* %clean, %install
- %clean section is empty
See https://fedoraproject.org/wiki/Packaging/ReviewGuidelines :
"MUST: Each package must have a %clean section, ...."
- Also %install does not contain any "cleaning" line.
https://fedoraproject.org/wiki/Packaging/Guidelines#PreppingBuildRootForInstall
* Directory ownership issue
- The directory %{python_sitelib}/ itself is owned by python and
should not be owned by this rpm.
* Documents
- As license information is in src/Pmw/Pmw_1_3/doc/copyright.html
at least this file should be included in %doc.
I guess
-------------------------------------------------
%doc src/Pmw/Pmw_1_3/doc/
-------------------------------------------------
is better.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list