[Bug 464424] Review Request: GROMACS - a Molecular Dynamics package

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=464424





--- Comment #27 from Jussi Lehtola <jussi.lehtola at iki.fi>  2008-10-03 07:39:18 EDT ---
(In reply to comment #17)
> Some notes:
> 
> * EVR
>   - At least EVR (Epoch-Version-Release) needs fixing:
>    
> https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Pre-Release_packages

Fixed.

> * configure
>   - Doesn't the following work?

Duh, much simpler. Thanks.

> * Namespace in %_bindir, generic names
>   - Your srpm installs many exectables under %_bindir, which is not desired.
>     Also some files has too generic names (like luck, wheel, highway, and so
> on),
>     which is rather a blocker.
>     Please move (almost all) executables under %_bindir to %_libexecdir/%name,
> for
>     example and add executables under %_bindir which are _really_ needed.

The problem is that GROMACS has a big bunch of independent analysis tools that
users need, all of which must be in the system path.

I renamed highway, luck, sigeps and wheel to g_highway, g_luck, g_sigeps and
g_wheel. I used autoreconf to regenerate the scripts.

I don't have access to the buildsystem yet, so I can't check whether it works
on F10.

> * Duplicate files

Thanks, fixed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.