[Bug 458784] Review Request: xcb-util - The xcb-util module provides a number of libraries which sit on top of libxcb

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=458784


Patrice Dumas <pertusus at free.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pertusus at free.fr




--- Comment #6 from Patrice Dumas <pertusus at free.fr>  2008-10-03 14:52:33 EDT ---
You could use 
make install DESTDIR=$RPM_BUILD_ROOT INSTALL='install -p' to keep 
header files timestamps.

You could do make check in %check.

rpmlint output is ignorable:
xcb-util-devel.i386: W: no-documentation

I'd propose a shorter summary:

  Convenience libraries sitting on top of libxcb

And for the devel summary I propose:

  Development and header files for xcb-util

There is a license issue, wm/reply_formats.c notice refers to COPYING
which isn't present.

In rm -rf %{buildroot}%{_libdir}/*.la, the -r is not needed. And the
-f isn't needeed too, I prefer personnally being warned when a file
I had to remove isn't present anymore.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.