[Bug 464424] Review Request: GROMACS - a Molecular Dynamics package

bugzilla at redhat.com bugzilla at redhat.com
Fri Oct 3 21:49:45 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=464424





--- Comment #32 from Dominik 'Rathann' Mierzejewski <rpm at greysector.net>  2008-10-03 17:49:43 EDT ---
(In reply to comment #27)
[...]
> > * Namespace in %_bindir, generic names
> >   - Your srpm installs many exectables under %_bindir, which is not desired.
> >     Also some files has too generic names (like luck, wheel, highway, and so
> > on),
> >     which is rather a blocker.
> >     Please move (almost all) executables under %_bindir to %_libexecdir/%name,
> > for
> >     example and add executables under %_bindir which are _really_ needed.
> 
> The problem is that GROMACS has a big bunch of independent analysis tools that
> users need, all of which must be in the system path.
> 
> I renamed highway, luck, sigeps and wheel to g_highway, g_luck, g_sigeps and
> g_wheel. I used autoreconf to regenerate the scripts.

gromacs-filenames.patch looks like an autotools update for the whole GROMACS.
I can't find what it really does among the hundereds of similar changes.
Please limit the patch to renaming the problematic binaries only.

Also I think more binaries should get the g_ prefix, but I'll look through the
list tomorrow.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list