[Bug 465382] Review Request: bouncycastle-mail - Additional libraries for Bouncy Castle

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=465382


Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |mtasaka at ioa.s.u-tokyo.ac.jp
               Flag|                            |fedora-review?




--- Comment #1 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2008-10-05 11:23:14 EDT ---
For 1.41-1

* Summary/Description
  - Would you change Summary/Description more informative?
    I don't think the Summary "Additional libraries" makes
    much sense.

* Naming
  - First of all, why is this srpm named as "bouncycastle-mail",
    not "bcmail"?

* License
  - License tag should be "MIT"

* SourceURL
  - SOURCE0 must be written with full URL:
    https://fedoraproject.org/wiki/Packaging/SourceURL

* (Build)Requires
  - I guess "BuildRequires: java-devel >= 1.7" is better than
    java-1.7.0-icedtea-devel.

* unpackaging source / removing precompiled binaries
  - Please unpack all sources in the tarball before removing
    precompiled binaries to make it sure that all precompiled
    binaries (including those in zip files if any) are
    correctly removed.

  ! By the way when using "unzip" adding "-qq" option is
    preferred. When using zip source tarball %setup -q
    uses this.

* absolute symlink
-----------------------------------------------------
W: symlink-should-be-relative /usr/share/java/gcj-endorsed/bcmail-1.41.jar
/usr/share/java/bcmail-1.41.jar
-----------------------------------------------------
  - Mainly for chroot reason and so on, Fedora requests that all
    symlinks should be relative, not absolute.

! %postun
-----------------------------------------------------
%postun
if [ $1 -eq 0 ] ; then
  if [ -x %{_bindir}/rebuild-gcj-db ]; then
    %{_bindir}/rebuild-gcj-db
  fi
fi
-----------------------------------------------------
  - While I am not familiar with gcj, would you explain why
    it is sufficient that these scripts are called only when
    [ $1 -eq 0 ] ? (please also refer to:
    https://fedoraproject.org/wiki/Packaging/GCJGuidelines )

* %attr
  - Although GCJGuidelines uses it, the part "%attr(-,root,root)"
    is completely redundant.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.