[Bug 465740] Review Request: rubygem-gettext - RubyGem of Localization Library and Tools for Ruby

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=465740





--- Comment #3 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2008-10-07 00:34:24 EDT ---
Hello, thank you for your comments.

(In reply to comment #2)
> -------------------------------------------------------------------------
> * The spec file MUST handle locales properly. This is done by using the
> %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
>    http://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files
> Could you BuildRequire gettext and use the %find_lang macro as depicted in the
> Guidelines? Will this cause a problem?

 - For this package "BR: gettext" is not needed because gettext .mo files
   are already shipped in gem.
   Also %find_lang is actually used (for symlinked mo files under
%_datadir/locale)
   as:
---------------------------------------------------------------------------
%find_lang rails
%find_lang rgettext
%{__cat} *.lang >> %{name}.lang

%files -n ruby-gettext-package -f %{name}.lang
---------------------------------------------------------------------------
   The problem is that %find_lang cannot handle files under %gemdir

> -------------------------------------------------------------------------
> * The package does not use the macro's consistently. e.g. the lines
>    %{__rm} -rf %{buildroot}%{gemdir}/bin/
>    ...
>    rm -rf %{buildroot}
> cause some inconsistency. 
> Also you use the "%{__command}" notation for some commands and "command"
> notation for the others. One example: "mv" should be "%{__mv}" if you want to
> be consistent.

  - Will fix them

> -------------------------------------------------------------------------
> * From http://fedoraproject.org/wiki/Packaging/Ruby  :
> The package must have a Requires and a BuildRequires on rubygems
> You only have
>    BuildRequires:  ruby(rubygems)  
>    Requires:  ruby(rubygems)

  - ruby(rubygems) pulls rubygems. And using virtual Provides for
    (Build)Requires is preferred (as well as perl) if possible.

> -------------------------------------------------------------------------
> *  Requires:       ruby(rubygems)
>    Requires:       irb
> Don't you need to require a specific version (or above)?  (just asking)
> -------------------------------------------------------------------------

   - This package already has "(Build)Requires: ruby(abi) = %rubyabi".

> * If the same Ruby library is to be packaged for use as a Gem and as a straight
> Ruby library without Gem support, it must be packaged as a Gem first. To make
> it available to code that does not use Ruby Gems, a subpackage called
> ruby-%{gemname} must be created in the rubygem-%{gemname} package such that
> 
> But your straight library is named ruby-%{gemname}-package. Can you explain
> why?

   - Because
     * non-gem version is actually called as ruby-gettext-package (on
       the upstream URL)
     * Also there is already a rpm named "ruby-gettext-package" in Fedora
       (which I currently maintain). This new rpm is to supersede
      current ruby-gettext-package after switching source from native
      tarball to gem.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.