[Bug 442268] Review Request: lxsession-lite - Lightweight X11 session manager

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=442268


Patrice Dumas <pertusus at free.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+




--- Comment #16 from Patrice Dumas <pertusus at free.fr>  2008-10-09 04:37:26 EDT ---
During the build, there is:

./config.status: line 1119: ./intltool-extract.in: No such file or directory
mv: cannot stat `intltool-extract.out': No such file or directory
chmod: cannot access `intltool-extract': No such file or directory
chmod: cannot access `intltool-extract': No such file or directory
./config.status: line 1119: ./intltool-merge.in: No such file or directory
mv: cannot stat `intltool-merge.out': No such file or directory
chmod: cannot access `intltool-merge': No such file or directory
chmod: cannot access `intltool-merge': No such file or directory
./config.status: line 1119: ./intltool-update.in: No such file or directory
mv: cannot stat `intltool-update.out': No such file or directory
chmod: cannot access `intltool-update': No such file or directory
chmod: cannot access `intltool-update': No such file or directory

However .mo files are installed.

* rpmlint is silent
* free software with license file
* match upstream
909c3b0f4c6e4855f64dfbb47467c0b3  lxsession-lite-0.3.6.tar.gz
* follow guidelines
* %files section right


I still suggest
make install DESTDIR=$RPM_BUILD_ROOT INSTALL='install -p'
to keep the man pages timestamps, but if they are generated this
is pointless, I haven't verified. In any case it is not a blocker.


More problematic, is the fact that source timestamps is not kept:
-rw-rw-r-- 1 dumas dumas 229644 Jun 11 20:49
../SOURCES/lxsession-lite-0.3.6.tar.gz
-rw-rw-r-- 1 dumas dumas 229644 Jun  8 19:13 lxsession-lite-0.3.6.tar.gz

please use wget -N, spectool -g or the appropriate curl option.
Since the stamps are similar it may also be an issue with sourceforge or
upstream, though.


If you fix this timestamp issue:
APPROVED

It seems to me that this package should need more testing before 
going into a stable branch, however, it could also be argued that
the whole lxde stack is not that mature and that it is better to have
more testing, and therefore add it to stable releases for maximal 
coverage.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.