[Bug 461338] Review Request: dahdi - Userspace tools to configure the DAHDI kernel modules

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=461338


Peter Robinson <pbrobinson at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+




--- Comment #11 from Peter Robinson <pbrobinson at gmail.com>  2008-10-09 17:06:31 EDT ---
It looks good now to me. Approved!

+ rpmlint output

$ rpmlint -v dahdi-tools-2.0.0-1.fc9.src.rpm
dahdi-tools.src: I: checking
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
$ rpmlint -v dahdi-tools*2.0.0-1.fc9.x86_64.rpm
dahdi-tools.x86_64: I: checking
dahdi-tools.x86_64: W: incoherent-init-script-name dahdi
dahdi-tools-debuginfo.x86_64: I: checking
dahdi-tools-devel.x86_64: I: checking
dahdi-tools-libs.x86_64: I: checking
4 packages and 0 specfiles checked; 0 errors, 1 warnings.

+ package name satisfies the packaging naming guidelines
+ specfile name matches the package base name
+ package should satisfy packaging guidelines
+ license meets guidelines and is acceptable to Fedora
+ license matches the actual package license

+ %doc includes license file
  you don't need to include README etc in all subpackages, just the main
package
+ spec file written in American English
+ spec file is legible

+ upstream sources match sources in the srpm

c09f880e67305bf5561c8030958b9fb9  dahdi-linux-2.0.0.tar.gz
31e48ed37e43662b0f8fbf146e192b66  dahdi-tools-2.0.0.tar.gz

+ package successfully builds on at least one architecture
  tested with a koji scratch build on all platforms
+ BuildRequires list all build dependencies
n/a %find_lang instead of %{_datadir}/locale/*
+ binary RPM with shared library files must call ldconfig in %post and %postun
+ does not use Prefix: /usr
+ package owns all directories it creates
+ no duplicate files in %files
+ %defattr line
+ %clean contains rm -rf $RPM_BUILD_ROOT
+ consistent use of macros
+ package must contain code or permissible content
n/a large documentation files should go in -doc subpackage
+ files marked %doc should not affect package
+ header files should be in -devel
n/a static libraries should be in -static
n/a packages containing pkgconfig (.pc) files need 'Requires: pkgconfig'
+ libfoo.so must go in -devel
+ devel must require the fully versioned base
+ packages should not contain libtool .la files
n/a packages containing GUI apps must include %{name}.desktop file
+ packages must not own files or directories owned by other packages
+ %install must start with rm -rf %{buildroot} etc.
+ filenames must be valid UTF-8

Optional:

n/a if there is no license file, packager should query upstream
n/a translations of description and summary for non-English languages, if
available
+ reviewer should build the package in mock
+ the package should build into binary RPMs on all supported architectures
+ review should test the package functions as described (basic testing)
+ scriptlets should be sane
n/a pkgconfig files should go in -devel
+ shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or
/usr/sbin

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.