[Bug 465511] Review Request: itext - A Free Java-PDF library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=465511





--- Comment #7 from Orcan Ogetbil <orcanbahri at yahoo.com>  2008-10-09 23:04:51 EDT ---
Thank you for the review.

(In reply to comment #6)
> Created an attachment (id=319888)
 --> (https://bugzilla.redhat.com/attachment.cgi?id=319888) [details]
> License analysis
> 
> Well,
> 
> * About itext-no-rups.patch:
>   - Would you explain what "it depends on proprietary com.sun classes"
>     means?
>     I am not familiar with Java, however as far as I checked quickly
> 
>     * About pdf-renderer.jar:
>       Is it different from the below?
>       https://pdf-renderer.dev.java.net/
>      
> https://pdf-renderer.dev.java.net/files/documents/6008/113009/PDFRenderer-2008_10_05-src.zip
>       It is available under LGPLv2+
>     * About dom4j-1.6.1.jar
>       Fedora has "dom4j" rpm, of which the license says BSD
> 
First I thought the com.sun classes the program depends were internal java
classes. But further investigation showed that these are actually pdf-renderer
dependencies. I packaged pdf-renderer (Bug #466394) and made it block itext. I
also enabled compilation of the rups libraries.

Thank you for pointing this out.

> * License
>   - My analysis attached.
>     The license tag should be
>     "(LGPLv2+ or MPLv1.1) and and ASL2.0 and BSD and MIT"
>      ( + "+ LGPLv2+ and CC-BY" if you build rups part)
> 
I made it (with rups) :
   License: (LGPLv2+ or MPLv1.1) and ASL 2.0 and BSD and MIT and LGPLv2+ and
CC-BY

> * Provides
>   - For upgrade path and so on, this type of Provides (Provides: iText)
>     should be full EVR (Epoch-Version-Release) specific.
>
This package does not have a specified epoch, so I just changed it to
   Provides:   iText == %{version}-%{release}
Is this good enough?
-----------------------------------------------------------------------------

I fixed everything else you asked. The updated files are:

SPEC: http://oget.fedorapeople.org/review/itext.spec
SRPM: http://oget.fedorapeople.org/review/itext-2.1.3-2.fc10.src.rpm

Note that you need to build and install bouncycastle bouncycastle-mail from
rawhide and pdf-renderer from Bug #466394 to build itext now.

There are some warnings while building the debuginfo package but I don't know
if those are important. Are those fixable?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.