[Bug 455953] Review Request: rakarrack - Audio effects processing rack for guitar

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=455953





--- Comment #11 from Orcan 'oget' Ogetbil <orcanbahri at yahoo.com>  2008-10-12 02:17:21 EDT ---
Thanks. Still there are some issues
*: needs fixed .  
?: doesn't need fixed but my preference is different than yours. Take it or
don't.

* rakarrack.desktop -> %{name}.desktop

? %{name} is a basic rack of effects for guitar... -> Rakarrack is a basic rack
of effects for guitar...

because this is a Description. Unless the application's name is strictly
beginning with a non-capital letter, I would refer to it capital-lettered in
sections like Summary or Description.

* This line needs to be in the %prep section:
   %configure --docdir=%{_docdir}/%{name}-%{version}
--htmldir=%{_docdir}/%{name}-%{version}

* These lines need to be in the %prep section too:
   %{__sed} -i 's/Icon=icono_rakarrack_128x128/Icon=rakarrack/'
%{buildroot}%{_datadir}/applications/rakarrack.desktop
   %{__sed} -i 's/Guitar Effects Processor/Real-time audio effects processing
rack for guitar/' %{buildroot}%{_datadir}/applications/rakarrack.desktop
   echo "GenericName=Digital audio effects processor" >>
%{buildroot}%{_datadir}/applications/rakarrack.desktop
   echo "Version=1.0" >> %{buildroot}%{_datadir}/applications/rakarrack.desktop

You may need to change the "%{buildroot}%{_datadir}/applications/" to "data/"

Basically, the %build section is for building/compiling, %install section is to
install the software into %{buildroot}. Everything else that can be done before
coming to these sections must be done in %prep.

*  %doc AUTHORS README
   %{_datadir}/doc/%{name}/COPYING
   %{_datadir}/doc/%{name}/html

This has problems. Now there are two document directories created:
/usr/share/doc/rakarrack /usr/share/doc/rakarrack-0.2.0
You only need one document directory. COPYING and html needs to go into %doc
(which is /usr/share/doc/rakarrack-0.2.0).
What you have to do is to make the program point onto the correct document
directory when you click on the Help->contents button. You may need to hack the
code (with some patch) to achieve this or most likely (and hopefully) it will
be enough just to pass certain parameters to the configure script. Look at the
output of "./configure --help" to see what parameters you may use.

------
So you decided to not add a new category? I'd say that would be convenient for
people dealing with audio software. :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.