[Bug 466762] Review Request: ipmitool - Utility for IPMI control

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=466762


Ville Skyttä <ville.skytta at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ville.skytta at iki.fi




--- Comment #4 from Ville Skyttä <ville.skytta at iki.fi>  2008-10-13 14:47:36 EDT ---
> service-default-enabled /etc/rc.d/init.d/ipmievd

I agree that it should not be.  Disabling its autostart is part of the patch
submitted in bug 466343:

-# chkconfig: 345 99 00
+# chkconfig: - 99 00

> incoherent-init-script-name ipmievd
> Fixable, or does this coorespond with what's in openipmi-tools?

IMHO, there's nothing to fix here - the init script specifically starts
ipmievd, not ipmitool... rpmlint is being a bit silly here.


"Obsoletes: OpenIPMI-tools < 2.0.14-3" missing (and possibly "Provides:
OpenIPMI-tools = 2.0.14-3" if you think it's necessary, see
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Renaming.2Freplacing_existing_packages)

>From bug 466343: "BuildRequires: freeipmi-devel" should be added, or freeipmi
support explicitly disabled for reproducible builds.

>From bug 466343: configure with --disable-dependency-tracking for slight build
speedup and cleaner build logs?

Source0 URL does not match recommended sf.net one:
http://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net

Wouldn't configuring with --enable-file-security be desirable?

"Requires: OpenIPMI" missing?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.