[Bug 455953] Review Request: rakarrack - Audio effects processing rack for guitar

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=455953





--- Comment #14 from David Timms <dtimms at iinet.net.au>  2008-10-15 09:35:54 EDT ---
(In reply to comment #11)
> * rakarrack.desktop -> %{name}.desktop
I looked at it and thought, maybe I should assign a variable to store the
complete path to .desktop in. Do people normally do things like that ?

Meanwhile I changed to point the spelt out path using %{name}

> ? %{name} is a basic rack of effects for guitar... -> Rakarrack is a basic rack of effects for guitar...
Overzealous search and replace. Fixed.

> * This line needs to be in the %prep section:
>    %configure --docdir=%{_docdir}/%{name}-%{version}
> --htmldir=%{_docdir}/%{name}-%{version}
I'm learning more about make configure and so on, thanks for these pointers.

> * These lines need to be in the %prep section too:
>    %{__sed} -i 's/Icon=icono_rakarrack_128x128/Icon=rakarrack/'
> %{buildroot}%{_datadir}/applications/rakarrack.desktop
>    %{__sed} -i 's/Guitar Effects Processor/Real-time audio effects processing
> rack for guitar/' %{buildroot}%{_datadir}/applications/rakarrack.desktop
>    echo "GenericName=Digital audio effects processor" >>
> %{buildroot}%{_datadir}/applications/rakarrack.desktop
>    echo "Version=1.0" >> %{buildroot}%{_datadir}/applications/rakarrack.desktop
Moved.

> You may need to change the "%{buildroot}%{_datadir}/applications/" to "data/"
Correct, and done.

> Basically, the %build section is for building/compiling, %install section is
> to install the software into %{buildroot}. Everything else that can be done
> before coming to these sections must be done in %prep.
First I've heard of it, but makes complete sense, as long as the build doesn't
build the icons / desktop files during make etc on the fly.

> *  %doc AUTHORS README
>    %{_datadir}/doc/%{name}/COPYING
>    %{_datadir}/doc/%{name}/html
> 
> This has problems. Now there are two document directories created:
> /usr/share/doc/rakarrack /usr/share/doc/rakarrack-0.2.0
> You only need one document directory. COPYING and html needs to go into %doc
> (which is /usr/share/doc/rakarrack-0.2.0).
> What you have to do is to make the program point onto the correct document
> directory when you click on the Help->contents button. You may need to hack 
Thanks for the sed hack.
In the end I still had to manually move the files to the doc-versioned dir so
that rpm and the app finds these things as expected.
It seems that this is an issue with some part of the source, ie the passed
--docdir and --htmldir are not properly used during configure, make and
install.
I am not sure what causes the html+COPYING files to end up in a non-versioned
doc dir, otherwise I would send a patch upstream.

> So you decided to not add a new category? I'd say that would be convenient for
> people dealing with audio software. :)
I wanted to, and a response from Matthias on f-packaging suggests it is OK, as
long as they are in addition to the standard categories, and prepended with X-.
Done.

Updated spec: http://members.iinet.net.au/~timmsy/rakarrack/rakarrack.spec
New .src.rpm:
http://members.iinet.net.au/~timmsy/rakarrack/rakarrack-0.2.0-4.fc9.src.rpm

- move non-install commands to setup
- fix configure .ini so that standard help path will be used

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.