[Bug 459675] Review Request: python-sybase - new package request

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459675





--- Comment #8 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2008-10-15 14:16:49 EDT ---
Well, for -4:

* installed files
  - Well, currently
    * sybasect.so
    * Sybase.py
    are not installed, which is apparently wrong
    (is this rpm really working for you?)

    As far as I checked this code, replacing the line
    "python setup.py install ...." by
--------------------------------------------------------
python setup.py install --root $RPM_BUILD_ROOT
--------------------------------------------------------
    correctly installs these files. Also with this
    change the following "rm $PYTHONPATH/site.*" line
    is not needed.

* General rpmlint issue
--------------------------------------------------------
python-sybase.i386: W: spurious-executable-perm
/usr/share/doc/python-sybase-0.39/doc/pstumble
python-sybase.i386: E: version-control-internal-file
/usr/share/doc/python-sybase-0.39/doc/.cvsignore
--------------------------------------------------------
  - Usually all files installed as %doc must have 0644 permission
    (and should not have executable permission)
  - .cvsignore file is not needed.


Also I am waiting for your another review request or
your pre-review of other person's review request.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.