[Bug 437192] Review Request: simdock - Fast and customizable dockbar

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=437192





--- Comment #9 from Jussi Lehtola <jussi.lehtola at iki.fi>  2008-10-18 16:43:00 EDT ---
(In reply to comment #8)
> Please set correct Status and Assigned To, do this before you start the review.

Thanks for the tip :)

> I will put br's in alphabetized order, however on a single line.
> 
> Where is the one br per line policy coming from?

I don't think it's a policy per se; my sponsor (Dominik) told me about it. And
he is right: even though you have to spend a minute or two typing the BRs in
this way, the end result is a lot cleaner to look at. You can see on one glance
what kind of software the package requires.

When you have many requires per line, you have to spend more time looking
around; when you have everything nicely in a column the list is much faster to
look through.

Since your other packages also have the same kind of BRs and they have passed
their reviews without problems, I won't make a fuss out of this. Decide for
yourself: which of these is nicest to read?

http://cvs.fedoraproject.org/viewvc/rpms/lynx/F-9/lynx.spec?revision=1.55&view=markup
http://cvs.fedoraproject.org/viewvc/rpms/firefox/F-9/firefox.spec?revision=1.304&view=markup
http://cvs.fedoraproject.org/viewvc/rpms/evolution/F-8/evolution.spec?revision=1.313&view=markup

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.