[Bug 468517] Review Request: saoimage - Utility for displaying astronomical images
bugzilla at redhat.com
bugzilla at redhat.com
Sun Oct 26 18:45:22 UTC 2008
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=468517
--- Comment #5 from Lubomir Rintel <lkundrak at v3.sk> 2008-10-26 14:45:21 EDT ---
(In reply to comment #3)
> By the way it may be good to check implicit function declaration
> by adding -Werror-implicit-function-declaration:
This sounds worthwhile. Due to the big amount of functions without prototypes
(there's at least one in vast majority of files) this would require substantial
effort. For now I included headers for functions covered by FORTIFY_SOURCE
where they were missing and I'll add prototypes for the rest if this becomes
mandatory part of packaging guidelines. (I encourage you to advocate for that)
New package:
SPEC: http://netbsd.sk/~lkundrak/SPECS/saoimage.spec
SRPM: http://netbsd.sk/~lkundrak/SRPMS/saoimage-1.35.1-2.el5.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list