[Bug 468579] Review Request: PyQuante - Python Quantum Chemistry

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468579


Fabian Affolter <fabian at bernewireless.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fabian at bernewireless.net




--- Comment #1 from Fabian Affolter <fabian at bernewireless.net>  2008-10-26 20:02:21 EDT ---
Only some quick comment about the rpmlint output and your spec file...

Spec file:

Detail about packaging python stuff:
https://fedoraproject.org/wiki/Packaging/Python

Name: PyQuante
 - The name of your package should be lower case
   https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Case_Sensitivity

BuildRequires
 - 'BuildRequires:   python' is missing

% files
 - Please follow the guidelines
https://fedoraproject.org/wiki/Packaging/Python#System_Architecture

%changelog
 - E mail address is missing
   https://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs

rpmlint output:

(In reply to comment #0)
> PyQuante.x86_64: E: non-executable-script
> /usr/lib64/python2.5/site-packages/PyQuante/Minimizers.py 0644

You can add something like 'find  *.py -type f | xargs chmod a+x' to fix this.

> PyQuante.x86_64: E: wrong-script-end-of-line-encoding
> /usr/lib64/python2.5/site-packages/PyQuante/pressure.py

If you have to remove DOS line endings in this file 'sed -i 's/\r$//' file.py'

> PyQuante.x86_64: W: invalid-license Modified BSD
> PyQuante-debuginfo.x86_64: W: invalid-license Modified BSD

For a valid license for Fedora, please take a look at
https://fedoraproject.org/wiki/Licensing

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.