[Bug 226557] Merge Review: xfig

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226557


Hans de Goede <hdegoede at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hdegoede at redhat.com




--- Comment #4 from Hans de Goede <hdegoede at redhat.com>  2008-10-30 06:35:07 EDT ---
Hi all,

As can be seen from the ChangeLog I'm a co-maintainer of xfig and I've been
doing most of the work on xfig lately. While looking at open xfig bugs to fix,
I forgot to look for a merge review. But I've found it now :)

So I'll be working on fixing the small list of Issues mentioned by Patrice.

(In reply to comment #3)
> rpmlint says:
> xfig.i386: W: no-documentation
> xfig.i386: W: obsolete-not-provided xfig-Xaw3d
> xfig-plain.i386: W: no-documentation
> xfig-common.i386: E: non-executable-script
> /usr/share/xfig/Libraries/Maps/USA/assemble 0644
> xfig-common.i386: E: non-executable-script
> /usr/share/xfig/Libraries/Maps/Canada/assemble 0644
> 
> The xfig.i386: W: obsolete-not-provided xfig-Xaw3d should certainly
> be fixed.
> 

Will do.

> I think that the non-executable script should be ignored, otherwise
> csh will become a dependency. Maybe a comment could be added (when 
> doing chmods in %prep?).
> 

Actually, I just tried them and those scripts are broken (tail +# should be
tail -n +#), and the output of them is already included, these are really
utility scripts for people editing these maps, so I think it would be best to
completely remove them, agreed?

> Some timestamps could be kept, for example after the iconv call, 
> there could be
>   touch -r $i $i.UTF-8
> But fixing all would require more work, not really that important.
> 

I'll fix the easy ones.

> I would have preferred to have virtual provides with parenthesis
> like  %{name}(executable)
> 

I agree, but it is too late for that now.

I don't want to make changes to the F-10 version of xfig so late in the game,
so I'm first going to do a branch request.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.