[Bug 468570] Review Request: webmin - new package

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468570





--- Comment #2 from Andy Theuninck <andy at gohanman.com>  2008-10-30 14:23:34 EDT ---
Whoops. CORRECT spec link:
http://gohanman.com/rpm/Fedora9/SPECS/webmin.spec

It's very loosely based on the upstream SPEC. I gutted out tons of the original
%pre/%post mess and made the %files section saner (so it actually includes
every file or directory the package creates).

I made a few changes to the spec based on suggestions in the linked bug. I'll
rebuild the SRPM later (no rpmbuild on my webhost). Changes that are just in
the spec, currently:
* Vendor tag removed
* License changed to GPL
* The last few extraneous echos [to stdout] removed

I left %clean as [ "%{buildroot}" != "/" ]. I don't see any harm in checking
against a possibly catastrophic mistake.

I have the backup of /etc/webmin in place still, although I'm copying it to
/var/webmin instead of leaving it as a dotfile in /etc. Size-wise, /etc/webmin
comes in at 1.1MB on my system. If that's too much space, there's probably no
real harm in getting rid of the backup entirely and letting rawhide/new release
testers fend for themselves.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.