[Bug 225798] Merge Review: gimp-help

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225798


Orcan 'oget' Ogetbil <orcanbahri at yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |orcanbahri at yahoo.com
         AssignedTo|nobody at fedoraproject.org    |orcanbahri at yahoo.com
               Flag|                            |fedora-review?




--- Comment #1 from Orcan 'oget' Ogetbil <orcanbahri at yahoo.com>  2008-10-30 14:48:57 EDT ---
I reviewed this package. The following issues need to be addressed for
compilance with the guidelines:

* The files AUTHORS, ChangeLog, COPYING, HACKING, NEWS, README, TERMINOLOGY
need to be listed under %doc

* The package owns
   %dir %{_datadir}/gimp
   %dir %{_datadir}/gimp/%{gimpsubver}
which are also owned by gimp. Note that the package Requires: gimp. The above
ownerships need to be dropped.

* %defattr(-,root,root,-) is preferred. 

* BuildRequires: libxml2
is not required since
   BuildRequires: libxslt
will pull that up

* Similarly
   BuildRequires: docbook-style-xsl
is not required. It will be pulled up by other dependencies. Am I wrong?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.