[Bug 467655] Review Request: yafaray - a raytracer for Blender.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467655





--- Comment #19 from Nicolas Chauvet (kwizart) <kwizart at gmail.com>  2008-10-30 18:53:36 EDT ---
(In reply to comment #18)
> It is not clear for me if we should keep 
> 
> _yafrayinterface.so and _yafqt.so
> 
> in blender's scripts directory or in %{_libdir}/blender, as
> Jochen suggested. Either way is fine for me.
The Shared Object are architecture dependent, thus needs to be in
%{_libdir}/blender (which will ends in the blender sub-package)
But /usr/lib64/libyafarayqt.so (and probably /usr/lib64/libyafarayplugin.so
also needs to be in the blender sub-pacakge. I don't think it is necessary to
run ldconfig in %post/%postun for the blender sub packages, as theses SO are
meant to be dlopened. (only needed for by /usr/lib64/libyafaraycore.so which
yafaray-xml links to).

Please check permissions for _yafqt.so and _yafrayinterface.so because they are
meant to be executable (if not they won't be stripped).


Please use Source0: instead of Source: (there is some side-effects without
versioned source).

The source archives cannot be downloaded over the internet.
You need to create a yafaray-snapshot.sh that will repackage such archtive for
you.

gcc-c++ is already in the buildroot. it have to be removed.

%{SOURCE1} is manually extracted. You have to move this task in %prep using :
%setup -q -n %{name}
%setup -q -D -T -a 1 -n %{name}

If you need to copy files that are not installed. Please use cp -p.
That will prevent to change the timestamps.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.