[Bug 361701] Package review: konserve - System tray application that performs periodic backups

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=361701


Orcan 'oget' Ogetbil <orcanbahri at yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |orcanbahri at yahoo.com




--- Comment #15 from Orcan 'oget' Ogetbil <orcanbahri at yahoo.com>  2008-10-31 17:59:47 EDT ---
This package needs some more work. Here are my notes:

* The license should be GPLv2+ and GFDL. The file doc/konserve/index.docbook
claims GFDL license for the documentation of the software. But I can't find the
text of GFDL inside the tarball. Can you contact upstream to ask for including
the text of GFDL in the tarball?

* The files AUTHORS, COPYING and ChangeLog must be in %doc

* Can you name the patches konserve-xxx.patch ? Also an explanation in the SPEC
file about what each of them does would be nice. The patches should also be
submitted upstream (unless they are very Fedora specific) and the links from
their bug tracking system should be put in the SPEC file.

* I don't think you need BR: libtool

* Fedora specific compilation flags are getting overridden. This needs fixed.

* --vendor="fedora" should be removed from new packages according to the new
guidelines.

* You are already patching the desktop file. Why are you using an
   --add-category="System"
in the desktop-file-install and not do this in the patch?

* Please follow the guidelines at
   http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GTK.2B_icon_cache
for installation of icons.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.