[Bug 461358] Review Request: weplab - Analyzing WEP encryption security on wireless networks

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=461358





--- Comment #2 from Fabian Affolter <fabian at bernewireless.net>  2008-09-07 07:19:43 EDT ---
(In reply to comment #1)

Thanks for reviewing my first package.

> Some quick comments on your spec:
> 
> - license is GPLv2+. Take a look at the haeders of the source: "or (at your
> option) any later version"

fixed

> - remove INSTALL from %doc, it generic information that is not needed when
> installed from rpm

fixed

> - remove NEWS from %doc, it's empty

fixed

> - the manpage should not have %doc

fixed

> - mockbuild fails:
>   checking for pcap_open_live in -lpcap... no
>   ERROR: You need libpcap-dev!
> So obviously this BuildRequires: libpcap-devel

fixed -> BuildRequires:  libpcap-devel

New files:

Spec URL: http://fab.fedorapeople.org/packages/SRPMS/weplab.spec
SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/weplab-0.1.5-2.fc9.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.