[Bug 459800] Review Request: python-py - Innovative python library containing py.test, greenlets and other niceties

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459800





--- Comment #2 from Thomas Moschny <thomas.moschny at gmx.de>  2008-09-07 10:40:09 EDT ---
(In reply to comment #1)
> I have to admit, it's terribly funny to "%define srcname py" and then go on to
> use "%{srcname}" in place of "py".  Ten keystrokes (twelve if you count the
> shift key) to replace two?  But that's your option as the maintainer.

Well, there are more reasons for defining macros than solely reducing the
number of keystrokes. Normally I use %{name} e.g. for the Url and Source tags, 
but in case of python packages %{name} doesn't work because of the leading
'python-', that's why there is %{srcname}.

Anyway, I removed %{srcname} here.

> 0.9.2 came out the same day you opened this ticket; did you want to update the
> package?

Thanks for the hint. Updating the package indeed simplified packaging a bit,
because upstream made some efforts towards a clean install using setuptools.

> With a license like that, you really need to be more specific about which parts
> have which license.  Otherwise the poor reviewer has to repeat the entire
> process you used to figure out the licensing information along with anyone who
> may maintain it in the future.

The specfile now has a more detailed list wrt licensing.

Spec URL: http://thm.fedorapeople.org/python-py.spec
SRPM URL: http://thm.fedorapeople.org/python-py-0.9.2-1.fc9.src.rpm

%changelog
* Sun Sep  7 2008 Thomas Moschny <thomas.moschny at gmx.de> - 0.9.2-1
- Update to 0.9.2.
- Upstream now uses setuptools and installs to %%{python_sitearch}.
- Remove %%{srcname} macro.
- More detailed information about licenses.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.