[Bug 461305] Review Request: pam_kcoda - coda auth/cred/session PAM module

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=461305





--- Comment #5 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2008-09-10 10:48:45 EDT ---
Only for debuginfo issue:

(In reply to comment #4)
> If you can't get -debuginfo populate, disable generation of the -debugingo package.
  We should not allow this. All packages must create debuginfo rpm correctly
unless they
  are noarch rpms, monos, or so.

  2 issues:
  - build log actually shows that Fedora specific compilation flags are not
honored
    correctly:
----------------------------------------------------------
+ CFLAGS='-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic
-fasynchronous-unwind-tables -fPIC'
+ export CFLAGS
+ make
mkdir -p ./dynamic
gcc -O2 -Dlinux -DLINUX_PAM -ansi -D_POSIX_SOURCE -Wall -Wwrite-strings
-Wpointer-arith -Wcast-qual -Wcast-align -Wtraditional -Wstrict-prototypes
-Wmissing-prototypes -Wnested-externs -Winline -Wshadow -pedantic -fPIC
-DPAM_DYNAMIC  -c pam_kcoda.c -o dynamic/pam_kcoda.o
-----------------------------------------------------------
    So -g debug option flag is not used.
    'make %{?_smp_mflags} CC="gcc $RPM_OPT_FLAGS"' seems to work
  - pam_kcoda.so is installed with 0644 permission. find-debuginfo.sh will
tries to strip binaries
    only with executable permission flag. pam_kcoda.so should be installed with
0755 permission
    (change SHLIBMODE).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.