[Bug 454220] Review Request: germanium - a download manager for eMusic.com

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=454220


Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |mtasaka at ioa.s.u-tokyo.ac.jp




--- Comment #28 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2008-09-10 13:53:44 EDT ---
For 0.2.2-4:

* Redundant (Build)Requires
  - I mischecked before, however
    * pygtk2-devel Requires pygobject2-devel
    * pygtk2 Requires pygobject2, pycairo (from explicit Requires)
      and gtk2 (from library dependencies)
      ! Note: pygtk2-devel does not require gtk2-devel
    So there are more redundant (Build)Requires.

  - Requires(post/postun): desktop-file-utils is not needed (this
    is not actually used)

* Other Requires
  - germanium/vfs_util.py contains:
----------------------------------------------------------
    19  from cStringIO import StringIO
    20  
    21  import gnomevfs
    22  
----------------------------------------------------------
    germanium/gconf_util.py contains:
----------------------------------------------------------
    21  import gconf
    22  import gtk
----------------------------------------------------------
    so, "Requires: gnome-python2-gnomevfs gnome-python2-gconf"
    seems needed.

* Desktop file
  - Category "Application" is deprecated and should be removed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.