[Bug 458054] Review Request: arm4 - Application Response Measurement (ARM) agent

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=458054


Jon Ciesla <limb at jcomserv.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |limb at jcomserv.net
         AssignedTo|nobody at fedoraproject.org    |limb at jcomserv.net




--- Comment #1 from Jon Ciesla <limb at jcomserv.net>  2008-09-19 11:01:48 EDT ---
Hi, I'll do a full review, and can sponsor you once this is approved.  Also,
I'd like to see some unofficial reviews of others' packages.  Post links here.

To begin with, rpmlint on SRPM:

arm4.i386: W: devel-file-in-non-devel-package /usr/lib/libarm4.so
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

arm4.i386: W: devel-file-in-non-devel-package /usr/lib/libarm4_null.so
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

Probably ok.

arm4.i386: W: non-standard-uid /var/arm4 arm4
A file in this package is owned by a non standard user. Standard users are:
root, bin, daemon, adm, lp, sync, shutdown, halt, mail, news, uucp, operator,
games, gopher, ftp, nobody.

arm4.i386: W: non-standard-gid /var/arm4 arm4
A file in this package is owned by a non standard group. Standard groups are:
root, bin, daemon, sys, adm, tty, disk, lp, mem, kmem, wheel, mail, news,
uucp, man, games, gopher, dip, ftp, lock, nobody, users.

Ok.  But might this not be better placed in /var/lib?  What is this dir for?

arm4.i386: W: no-reload-entry /etc/rc.d/init.d/arm4
In your init script (/etc/rc.d/init.d/your_file), you don't have a 'reload'
entry, which is necessary for good functionality.

Fix.  If the daemon doesn't support this, just duplicate the restart entry.

arm4-devel.i386: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

Fix.

arm4-java.i386: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

Fix.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.