[Bug 459916] Review Request: freedink-dfarc - Frontend and .dmod installer for GNU FreeDink

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459916


Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #19 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2008-09-24 04:00:14 EDT ---
(In reply to comment #18)
> By the way, under F9 and mock, I keep getting rpmlint errors about g+w
> directories:
> freedink-dfarc.i386: E: non-standard-dir-perm
> /usr/share/doc/freedink-dfarc-3.2.1 02755

I don't get such strange behavoir...

For 3.2.1-1:

* scriptlet
---------------------------------------------------
    %post
    #
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#desktop-database
    update-desktop-database &> /dev/null || :
    #
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GTK.2B_icon_cache
    touch --no-create %{_datadir}/icons/hicolor
    if [ -x %{_bindir}/gtk-update-icon-cache ] ; then
      %{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || :
    # http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#mimeinfo
!!! update-mime-database %{_datadir}/mime &> /dev/null || :
    fi
---------------------------------------------------
    The line marked as !!! is inside of if-fi structure (same for %postun)

* macros in comment
---------------------------------------------------
# Don't install desktop files, use %post instead
---------------------------------------------------
  - In the comment (and %changelog), use %% instead of % to avoid
    unwanted macros expansion.

* %changelog
  - Please keep the old %changelog entry

Fix the issues above, all others are good.

-------------------------------------------------------------
    This package (freedink-dfarc) is APPROVED by mtasaka
-------------------------------------------------------------

Please follow the procedure written on:
http://fedoraproject.org/wiki/PackageMaintainers/Join
from "Get a Fedora Account".
After you request for sponsorship a mail will be sent to sponsor 
members automatically (which is invisible for you) which notifies 
that you need a sponsor. After that, please also write on
this bug for confirmation that you requested for sponsorship and
your FAS (Fedora Account System) name. Then I will sponsor you.

If you want to import this package into Fedora 8/9, you also have
to look at
http://fedoraproject.org/wiki/Infrastructure/UpdatesSystem/Bodhi-info-DRAFT
(after once you rebuilt this package on koji Fedora rebuilding system).

If you have questions, please ask me.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.