[Bug 493527] Review Request: perl-PlRPC - Interface for building pServer Clients

bugzilla at redhat.com bugzilla at redhat.com
Thu Apr 2 07:08:35 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=493527


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #1 from Parag AN(पराग) <panemade at gmail.com>  2009-04-02 03:08:34 EDT ---
Review:
+ package builds in mock (rawhide i586).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1272115
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
5361e137e56d037c5e796926ecb5300b  PlRPC-0.2020.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
+ Package perl-PlRPC-0.2020-1.fc11.noarch =>
  Provides: perl(Bundle::PlRPC) = 0.03 perl(RPC::PlClient) = 0.2020
perl(RPC::PlClient::Comm) = 0.1002 perl(RPC::PlClient::Object)
perl(RPC::PlServer) = 0.2020 perl(RPC::PlServer::Comm) = 0.1003
perl(RPC::PlServer::Test) = 0.01
  Requires: perl >= 0:5.004 perl(IO::Socket) perl(Net::Daemon)
perl(Net::Daemon::Log) perl(Net::Daemon::Test) perl(RPC::PlClient::Comm)
perl(RPC::PlServer) perl(RPC::PlServer::Comm) perl(Storable) perl(strict)
perl(vars)


APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list