[Bug 492164] Review Request: healpix - Hierarchical Equal Area isoLatitude Pixelization of a sphere

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492164





--- Comment #7 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-04-03 12:00:31 EDT ---
rpmlint output:
chealpix.x86_64: W: no-soname /usr/lib64/libchealpix.so
chealpix.x86_64: W: shared-lib-calls-exit /usr/lib64/libchealpix.so
exit at GLIBC_2.2.5
chealpix-devel.x86_64: W: no-documentation
healpix-fortran.x86_64: W: no-soname /usr/lib64/libgif.so
healpix-fortran.x86_64: W: no-soname /usr/lib64/libhealpix.so
healpix-fortran-devel.x86_64: W: no-documentation
6 packages and 0 specfiles checked; 0 errors, 6 warnings.

- Did you send the shared library patch upstream? IIRC some package sponsors
have frowned on Fedora specific patches to build shared libraries.

- Even though there is only one C header, it might be logical to put it into
the same place as the Fortran module files.

- Maybe Fortran package should be named just 'healpix'.


MUST: The package does not yet exist in Fedora. The Review Request is not a
duplicate. OK
MUST: The spec file for the package is legible and macros are used
consistently. OK
MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}. OK
MUST: The package must be licensed with a Fedora approved license and meet the 
Licensing Guidelines. OK

MUST: The License field in the package spec file must match the actual license.
OK
 - The java library seems to be under LGPLv2+, but since it isn't included no
problem.

MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. OK
MUST: The package MUST successfully compile and build into binary rpms. OK
MUST: The spec file MUST handle locales properly. OK
MUST: Optflags are used and time stamps preserved. OK

MUST: Packages containing shared library files must call ldconfig. NEEDSFIX
- chealpix and healpix-fortran need to call ldconfig in %post phase.

MUST: A package must own all directories that it creates or require the package
that owns the directory. OK
MUST: Files only listed once in %files listings. OK
MUST: Permissions on files must be set properly. OK
MUST: Clean section exists. OK
MUST: Large documentation files must go in a -doc subpackage. OK
MUST: All relevant items are included in %doc. Items in %doc do not affect
runtime of application. OK
MUST: Header files must be in a -devel package. OK
MUST: Static libraries must be in a -static package. OK
MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. OK
MUST: If a package contains library files with a suffix then library files
ending in .so must go in a -devel package. OK

MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency. NEEDSFIX
- fortran-devel must require fortran since the libraries are in fortran.

MUST: Packages does not contain any .la libtool archives. OK
MUST: Desktop files are installed properly. OK
MUST: No file conflicts with other packages and no general names. OK
MUST: Buildroot cleaned before install. OK
SHOULD: %{?dist} tag is used in release. OK
SHOULD: If the package does not include license text(s) as separate files from
upstream, the packager should query upstream to include it. OK
SHOULD: The package builds in mock. OK

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.